Sending a private message without cc causes a 500 error

[freamon@community.nodebb.org]

@julian I've added support to PieFed to successfully receive Create / Note as a PM from NodeBB.

From Nutomic's PR, it looks like you'll continue you get Create / ChatMessage from them, as also you will from PieFed. This currently fails, as I guess that it converts them into a Create / Note, but then complains of there being no 'cc'.

It doesn't make sense for PMs to be 'carbon copied' to anyone, so I'll raise an Issue at your repo.

[julian@community.nodebb.org]

@freamon thanks! Happy to look into handling Create(ChatMessage)... I think the error aside, NodeBB would drop it anyway since ChatMessage isn't an expected post type.

[freamon@community.nodebb.org]

@julian Oh, I've just realised I read Nutomic's PR the wrong way around. After 2.0, you'll start getting Notes from them. If 'ChatMessage' processing isn't worth handling by NodeBB, I can change PieFed to send you Notes instead.

[rikudou@community.nodebb.org]

@freamon As others have said, ChatMessage is non-standard. The Create/Note is not particularly great for private messages, but whatever. Anyway, cc is not a required field of Note nor Create, so any software that would complain has a bug.

[freamon@community.nodebb.org]

@rikudou Yeah, sorry, I didn't mean to derail this thread. The GitHub issue was intended to only really be about the 'cc' problem, because it looks like PieFed will have to start sending Create/Note to non-Lemmy platforms anyway, but it'd easier if 'cc' doesn't have to be artificially included to keep NodeBB happy.

[julian@community.nodebb.org]

@freamon @rikudou

Missing cc on incoming non-public payload causes note assertion failure · Issue #13202 · NodeBB/NodeBB

https://community.nodebb.org/topic/18642/sending-a-private-message-without-cc-causes-a-500-error/14

GitHub (github.com)

[julian@community.nodebb.org]

In a bit of code that is too clever for my own good, I collapse to and cc into a single deduplicated array with:

const recipients = new Set([...object.to, ...object.cc]);

Which of course assumes that both properties are iterable. That has now been changed to an even clever-er (and less readable):

const recipients = new Set([...(object.to || []), ...(object.cc || [])]);

[rikudou@community.nodebb.org]

@julian Wouldn't ?? be better?

[julian@community.nodebb.org]

@rikudou maybe? Nullish coalescing sounds really cool, but I've avoided it for years because of browser compatibility.

Node has had support forever (since v14, I've discovered), but I just don't know how to use it is all

[edie@lemmy.ml]

It seems all of the test instances are down? I get a 502 no matter which of voyager.lemmy.ml, enterprise.lemmy.ml, and ds9.lemmy.ml I try to open

[nutomic@lemmy.ml]

Yes not sure whats wrong there, the server was using a lot of cpu for no reason. Restart fixed it for now, let me know if it happens again.

[edie@lemmy.ml]

Voyager still has an issue, but the others seem to work now

[nutomic@lemmy.ml]

That instance runs Lemmy 1.0 which is still in alpha state, and the frontend is not compatible yet. So only the api works there.